Daisy

Merge lp://staging/~brian-murray/daisy/user-package-cache into lp://staging/daisy

  1. user-package-cache
  2. Merge into trunk
Proposed by Brian Murray
Status: Merged
Merged at revision: 224
Proposed branch: lp://staging/~brian-murray/daisy/user-package-cache
Merge into: lp://staging/daisy
Diff against target: 645 lines (+429/-19)
18 files modified
daisy/launchpad.py (+374/-0)
daisy/schema.py (+5/-0)
setup/init_retracer.sh (+1/-1)
submit.wsgi (+3/-3)
submit_core.wsgi (+3/-3)
tools/90day_unique_users.py (+1/-1)
tools/90day_unique_users_for_day.py (+1/-1)
tools/add_system_identifiers.py (+1/-1)
tools/amqp_put.py (+1/-1)
tools/back_populate_counts_by_problem_type.py (+1/-1)
tools/create_apport_report.py (+1/-1)
tools/fill_unique_users_with_value.py (+1/-1)
tools/import_bugs.py (+1/-1)
tools/import_user_packages.py (+31/-0)
tools/insert_sample_data.py (+1/-1)
tools/remove_not.py (+1/-1)
tools/show_unique_users_per_day.py (+1/-1)
tools/unique_users_daily_update.py (+1/-1)
To merge this branch: bzr merge lp://staging/~brian-murray/daisy/user-package-cache
Reviewer Review Type Date Requested Status
Evan (community) Approve
Review via email: mp+147477@code.staging.launchpad.net

Description of the change

This will create a UserBinaryPackages column family and includes a tool for loading data into that column family. The tool contains the name of some teams in Ubuntu Engineering that are subscribed to a large number of packages which is slow to look up. Instead of querying Launchpad for what packages these teams are subscribed to, with every request, we will instead cache this information and update it one time a week.

To implement this I imported launchpad.py as it has all the logic already for using the Launchpad API to determine what source packages a user is subscribed to and what binary packages are produced by those source packages. However, launchpad.py isn't avaible on the daisy system and I'm not certain how to resolve this.

To post a comment you must log in.
Revision history for this message
Evan (ev) wrote :

To resolve the launchpad.py issue, I would suggest we move launchpad.py into lp:daisy and make lp:errors do a "from daisy import launchpad".

This will potentially require changing lp:canonical-memento. It's not immediately clear to me that /srv/daisy.ubuntu.com/production/whoopsie-daisy contains both daisy/ and errors/ directories.

Other than that, this looks good.

Thanks!

lp://staging/~brian-murray/daisy/user-package-cache updated
215. By Brian Murray

move launchpad.py from errors to daisy, add more teams for whom we should cache packages

216. By Brian Murray

create a daisy directory and move code into it

217. By Brian Murray

modify some configuration imports to be from daisy

218. By Brian Murray

submit_core.wsgi: update imports for daisy directory

Revision history for this message
Brian Murray (brian-murray) wrote :

I've moved launchpad.py into the daisy branch and created a daisy folder so that we can use 'from daisy import launchpad' in errors. I also modified many an import for this change.

I've tested this in an lxc container pointing to the production database and everything seemed good.

lp://staging/~brian-murray/daisy/user-package-cache updated
219. By Brian Murray

launchpad.py: pull in last change to launchpad.py from errors

Revision history for this message
Evan (ev) wrote :

Looks good! We'll need to change things around in lp:canonical-memento to point to the correct location.

Revision history for this message
Evan (ev) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: