Code review comment for lp://staging/~brian-murray/daisy/remove-sandbox-dir-after-retrace
Revision history for this message
| Brian Murray (brian-murray) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
513534c
demo site
(Get the code!)
I think removing --sandbox-dir does more than we actually want. I'm suggesting that we stop using apport-retrace's "--sandbox-dir" option but continuing to use "--cache".
"--sandbox-dir" for retracer.py is a combination of both of these as setup_cache returns the directory for "--sandbox-dir" for apport-retrace and the directory for "--cache". So by not using retracer.py's --sandbox-dir we'll lose the benefit of cacheing deb files.