Code review comment for lp://staging/~brian-murray/daisy/raring-eol

Revision history for this message
Evan (ev) wrote :

On 31 January 2014 17:29, Brian Murray <email address hidden> wrote:
> Given that whoopsie expects only a 200 or 400 response code:
>
> if (response == 200 || response == 400)
> success = TRUE;
> else
> success = FALSE;
>
> We shouldn't be returning a 410 or 501. We could updated whoopsie in Trusty with these new response codes and then check the X-Whoopsie-Version: to decide whether or not to return the new codes.

Given that this code is specifically for raring, shouldn't we just
reuse the 400 error code?

« Back to merge proposal