Ubuntu Autopilot Tests

Merge lp://staging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test into lp://staging/ubuntu-autopilot-tests/ubuntu-experience-tests

  1. contacts_dbus_test
  2. Merge into ubuntu-experience-tests
Proposed by Leo Arias
Status: Work in progress
Proposed branch: lp://staging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test
Merge into: lp://staging/ubuntu-autopilot-tests/ubuntu-experience-tests
Prerequisite: lp://staging/~elopio/ubuntu-autopilot-tests/fix_packaging
Diff against target: 205 lines (+129/-16)
4 files modified
debian/control (+3/-0)
debian/rules (+1/-0)
tests/test_helpers.py (+113/-0)
ubuntu_experience_tests/helpers.py (+12/-16)
To merge this branch: bzr merge lp://staging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test
Reviewer Review Type Date Requested Status
Leo Arias (community) Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+225595@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-06-24.

Commit message

Unit tests for ContactsDbusService.

Description of the change

Add some unit tests for ContactsDBusService. Also simplify get_vcard_uid and allow it to handle all newlines, not just CRLF newlines.

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) : Posted in a previous version of this proposal
review: Needs Fixing (code review)
Revision history for this message
Brendan Donegan (brendan-donegan) wrote : Posted in a previous version of this proposal

see my comments, i'll update the rest later

Revision history for this message
Leo Arias (elopio) : Posted in a previous version of this proposal
Revision history for this message
Brendan Donegan (brendan-donegan) wrote : Posted in a previous version of this proposal

So how about getting this merged and then we can move it to address-book-app ;)

Revision history for this message
Leo Arias (elopio) : Posted in a previous version of this proposal
review: Needs Fixing
Revision history for this message
Brendan Donegan (brendan-donegan) wrote : Posted in a previous version of this proposal

That's correct - whoops

Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

One more detail, the new deps on debian/control are missing the commas to separate them.

Please run bzr bd to make sure that the package still builds.
Francis has this half automated to get jenkins running it for us.

review: Needs Fixing
Revision history for this message
Leo Arias (elopio) : Posted in a previous version of this proposal
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:30
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test/+merge/224321/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/6/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1429/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2384/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/6/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Brendan Donegan (brendan-donegan) wrote : Posted in a previous version of this proposal

Ran bzr bd and built succesfully

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:31
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test/+merge/224321/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/8/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1450/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/8
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1742/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2416
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2416/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9147

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/8/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:31
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/9/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1470/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/9
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1757/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2437
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2437/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9163

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/9/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

There seems to be a problem with the packaging. I'll take a look.
Your code looks good, thanks.
Please move it to address book app or address book service as soon as possible.

review: Approve
Revision history for this message
Leo Arias (elopio) wrote :

I've resubmit with the fixed packaging branch as a prerequisite to see if the tests pass on Jenkins.

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:31
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/12/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1563/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/12
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/12
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/12
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1841/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2552
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2552/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9288

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/12/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:31
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/13/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1564/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/13
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1842/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2553
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2553/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9289

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/13/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Leo Arias (elopio) wrote :

Oh, I get the problem. You have your test_helpers outside ubuntu_experience_tests.
Please move them into that directory.

review: Needs Fixing
Reply
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

No - I deliberately moved them outside as we do not want these to be run as part of the ubuntu_experience suite itself. They should be run only at build time - the packaging needs to be updated to do this - I was waiting for your input on that. I'll catch you when you're around to discuss it further.

Reply
lp://staging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test updated
32. By Brendan Donegan

Run unit tests during builds and update test code to run under python3. Also revert the addCleanup change as it's not working

33. By Brendan Donegan

Use nose to run the tests instead

34. By Brendan Donegan

Merged from trunk

Unmerged revisions

34. By Brendan Donegan

Merged from trunk

33. By Brendan Donegan

Use nose to run the tests instead

32. By Brendan Donegan

Run unit tests during builds and update test code to run under python3. Also revert the addCleanup change as it's not working

31. By Brendan Donegan

Fix control file and flake8 error in helpers.py

30. By Brendan Donegan

Pass callables in addCleanup

29. By Brendan Donegan

Use addCleanup instead of tearDown

28. By Brendan Donegan

flake8 fixes

27. By Brendan Donegan

Add python3-dbus and python3-dbusmock to Build-Deps

26. By Brendan Donegan

Found a better home for the unit tests

25. By Brendan Donegan

Add unit tests for ContactsDbusService

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches