Code review comment for lp://staging/~brendan-donegan/hwcert-tools/batch_query_fix

Revision history for this message
Daniel Manrique (roadmr) wrote :

Silently ignoring exceptions is bad (tm). I suggest at least logging the exception's error message. The merge request for checkbox-message-get-c4 has an example of how to do that.

Other than that this look awesome and will work well on both python2 and python3 which rocks!

review: Needs Fixing

« Back to merge proposal