Code review comment for lp://staging/~brendan-donegan/checkbox/verification_interaction_jobs

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Unfortunately it seems Marc was potentially talking about a non-existent 'feature' - Reactor.fire() just does the following to get the handler for the event:

handlers = self._event_handlers.get(event_type, ())

Just a simple dictionary lookup, no regexes involved. We could debate the merits of using pattern matching on signal handlers here (more flexible, put potentially slower), or we could just go with what works now.

review: Needs Resubmitting

« Back to merge proposal