Merge lp://staging/~brendan-donegan/checkbox/plainbox_whitelists into lp://staging/checkbox
Proposed by
Brendan Donegan
| Status: | Merged |
|---|---|
| Approved by: | Zygmunt Krynicki |
| Approved revision: | 1844 |
| Merged at revision: | 1842 |
| Proposed branch: | lp://staging/~brendan-donegan/checkbox/plainbox_whitelists |
| Merge into: | lp://staging/checkbox |
| Diff against target: |
58 lines (+14/-2) 2 files modified
plainbox/plainbox/impl/box.py (+10/-0) plainbox/plainbox/impl/test_box.py (+4/-2) |
| To merge this branch: | bzr merge lp://staging/~brendan-donegan/checkbox/plainbox_whitelists |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zygmunt Krynicki (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Added an option to plainbox to read run patterns from a file (a whitelist is the commonly used term). These are simply appended to the set of run patterns used by plainbox. In the medium term we need to probably think about where run patterns will reside, but for now this makes whitelists work.
To post a comment you must log in.
Revision history for this message
| Zygmunt Krynicki (zyga) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
11:27 < zyga> brendand: so looking at your merge request
11:27 < zyga> brendand: I see both a TODO and a "utf-8" on line 8-12 of the diff
11:29 < brendand> zyga, the "utf-8" shouldn't be there
11:29 < brendand> zyga, i'm removing that
11:29 < zyga> brendand: thanks