Unity

Code review comment for lp://staging/~brandontschaefer/unity/lp.1131646-fix

  1. lp.1131646-fix
  2. Merge into trunk
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

+bool Controller::HandleStartInitiateEvent()
+bool Controller::HandleStopInitiateEvent()

What about using different naming? Such {Start,Stop}DetailMode or better?

Probably it would be better to change the compiz option names also, since they generates functions that doesn't represent anymore what they say. Don't you agree?

Would be now possible to test the controller also?

133 + void NextDetailRow();
134 + void PrevDetailRow();
135 + bool HasNextDetailRow() const;
136 + bool HasPrevDetailRow() const;

Are probably not needed anymore, right (also in the impl)?

« Back to merge proposal