Nice work, overall it looks fine, just few things:
143 - if (detail_selection_index >= (unsigned int) 1) 232 + return (detail_selection_index > 0);
doesn't compile on raring g++... Probably we should wait a little.
478 + std::vector<LayoutWindow::Vector> rows = GetRows(windows, max_bounds); 235 +void SwitcherModel::SetRowSizes(std::vector<int> row_sizes)
Use const& please.
174 + for (unsigned int i = 0; i <= n; i++)
++i is nicer. Also you should make sure that n is < row_sizes_.size().
« Back to merge proposal
Nice work, overall it looks fine, just few things:
143 - if (detail_ selection_ index >= (unsigned int) 1) selection_ index > 0);
232 + return (detail_
doesn't compile on raring g++... Probably we should wait a little.
478 + std::vector< LayoutWindow: :Vector> rows = GetRows(windows, max_bounds); :SetRowSizes( std::vector< int> row_sizes)
235 +void SwitcherModel:
Use const& please.
174 + for (unsigned int i = 0; i <= n; i++)
++i is nicer. Also you should make sure that n is < row_sizes_.size().