Code review comment for lp://staging/~brandontschaefer/unity/fix-711199

Revision history for this message
Michal Hruby (mhr3) wrote :

89 + markup << g_variant_get_string(it->second, NULL);

Values in the Hints map are instances of unity::glib::Variant (which have a GVariant* operator), please use the GetString method (which is NULL safe).

93 + markup << "Sorry, there is nothing that matches your search.";

This needs to be marked for translation - just use _("Sorry, ...")

review: Needs Fixing

« Back to merge proposal