Code review comment for lp://staging/~brandontschaefer/unity/fix-711199

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

I was checking active_lens_->lens() because there was a problem before where the active home lens would get passed in with out actually having a lens() which would cause a seg fault. That has now been fix/changed so I remove that! (Tested, now no seg fault yay!)

Fixed style problems (there were other style errors; now fixed!), now using nux::color::White, and now markup uses sstream!

As for the normal results view, it is still getting shown how it normally does. The no-result-message is apart of the same layout so when the results == 0 the layout is empty. Then I change the layouts ContentDistribution to nux::MAJOR_POSITION_CENTER, which draws the text in the middle of the dash. When there are > 0 results I change it back to nux::MAJOR_POSITION_START (default), so the new results get draw back where they should. (Instead of the middle!)

« Back to merge proposal