Code review comment for lp://staging/~brandontschaefer/compiz/fix-lp.892012

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Hmm it seems to overwrite them :). For example with the draft you've made:

If out last state was not maxed, and we go into a V Max we save X,Y,W,H. This should be our orig position.

Then we go to a full max (V + H), in the Vert if statement we re-save Y, H (since are state is also a Horz max), and in the Horz Max we re-save the X, W causing the new position to be save where it was in the Vert Max position ie. the bug :). Sooo I suppose I should look into why saving is overwriting the window cords?

Also some strange thing be happening with your changes, when I move to a vert maxed the window slowly decreases its width? Its actually pretty cool looking...but something must be off...

« Back to merge proposal