Juju Charms Collection
squid-forwardproxy package

Merge lp://staging/~blr/charms/precise/squid-forwardproxy/rutabaga-auth-helper into lp://staging/~canonical-launchpad-branches/charms/precise/squid-forwardproxy/trunk

Proposed by Kit Randel on 2015-11-30

Status:	Merged
Merged at revision:	34
Proposed branch:	lp://staging/~blr/charms/precise/squid-forwardproxy/rutabaga-auth-helper
Merge into:	lp://staging/~canonical-launchpad-branches/charms/precise/squid-forwardproxy/trunk
Diff against target:	146 lines (+49/-20) 3 files modified config.yaml (+6/-7) hooks/hooks.py (+39/-13) metadata.yaml (+4/-0)
To merge this branch:	bzr merge lp://staging/~blr/charms/precise/squid-forwardproxy/rutabaga-auth-helper
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Colin Watson (community)		2015-11-30	Approve on 2015-12-02
Review via email: mp+278920@code.staging.launchpad.net

* Add wait_for_auth_helper config value, allowing delayed config_changed hook until auth-helper-relation-joined.
* Remove 'run' config.

52. By Kit Randel on 2015-11-30: Rename auth-helper to squid-auth-helper.
53. By Kit Randel on 2015-11-30: Avoid mutating state of wait_for_auth_helper.
54. By Kit Randel on 2015-12-01: Prevent config parsing if not STATE_STARTED.
55. By Kit Randel on 2015-12-01: Update service ports independantly of configuration parsing in config_changed().
56. By Kit Randel on 2015-12-01: Set initial HOOK_START value to False.

Revision history for this message

Colin Watson (cjwatson) on 2015-12-02:

review: Approve

57. By Kit Randel on 2015-12-03: Add logging...
58. By Kit Randel on 2015-12-03: * Remove juju/general-info relations
* Add additional auth-helper relation symlinks.
59. By Kit Randel on 2015-12-06: Only squid-auth-helper-relation-joined implemented.
60. By Kit Randel on 2015-12-06: Manage hook state more consistently.

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

People subscribed via source and target branches

to all changes: