Code review comment for lp://staging/~bloodearnest/django-preflight/optional-settings

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

09:35 < nessita> bloodearnest, branch looks great, I'm approving. Any chance you can add a test where a setting inside a dict is expected to be masked?
09:35 < nessita> such as the database setting
09:39 < bloodearnest> nessita, good idea, will do
09:39 < nessita> bloodearnest, thanks, will leave my vote in there

review: Approve

« Back to merge proposal