Juju Charms Collection
rabbitmq-server package

Code review comment for lp://staging/~bloodearnest/charms/trusty/rabbitmq-server/add-nagios-service-groups

  1. Trusty Tahr (14.04)
  2. add-nagios-service-groups
  3. Merge into trunk
Revision history for this message
Cory Johns (johnsca) wrote :

Simon,

The CI failure appears to be due to a cert issue in the upstream branch, which has been reported in this bug: https://bugs.launchpad.net/charms/+source/rabbitmq-server/+bug/1436014

The changes in this MP seem reasonable, and setting and unsetting the new config option seems to work without error (although I am not entirely clear how to verify the expected result), so I'm willing to give this MP my +1. However, getting the test failure fixed upstream will very much make these reviews cleaner going forward.

review: Approve
Reply

« Back to merge proposal