Code review comment for lp://staging/~bloodearnest/charms/precise/gunicorn/cleanup

Revision history for this message
Michael Nelson (michael.nelson) wrote :

+1. I'm now using this version of the charm for deploying a new service (as I needed the env_extra option).

Most of the green diff below is just the result of syncing a recent charm-helpers.

Great to see some tests, and great to trim down the hooks.py by using charmhelpers instead.

Thanks!

review: Approve

« Back to merge proposal