Juju Charms Collection
landscape-client package

Code review comment for lp://staging/~bjornt/charms/precise/landscape-client/relation-depart-no-register

  1. Precise Pangolin (12.04)
  2. relation-depart-no-register
  3. Merge into trunk
Revision history for this message
Björn Tillenius (bjornt) wrote :

On Thu, Dec 05, 2013 at 12:03:16PM -0000, Adam Collard wrote:
> Review: Needs Fixing
>
> Can you please mark the RV issue as not being private? I should be
> able to see the feedback on there without auth-ing.

Indeed. It's public now.

> Few comments on RV, overall looks OK, but I'd like to look again
> before it gets landed, so marking as Needs Fixing.

I've replied to all comments.

« Back to merge proposal