Code review comment for lp://staging/~bjornt/charms/precise/landscape-client/extra-meta-data

Revision history for this message
Björn Tillenius (bjornt) wrote :

On Thu, Mar 07, 2013 at 07:10:34PM -0000, Marco Ceppi wrote:
> Review: Needs Information
>
> Hi Björn, Thanks for submitting this merge! As far as the changes you
> have submitted, they look good. However, I have some concern about what
> this will do to currently deployed landscape-client charms. With this
> change you've modified the way meta-data is stored (moving it from
> juju-info file to meta-data.d directory). When users run upgrade-charm
> the old data will not be created which produces an inconsistency and
> potential breakage for users currently deploying this charm.

Hi Marco,

thanks for the review. We decided we don't have to provide
backwards-compatibility, since no released version of landscape-client
has this functionality yet. In order to make use of the juju integration
you have to use the trunk version of landscape-client, and it's expected
that you might have to reinstall if you do that.

« Back to merge proposal