Code review comment for lp://staging/~bjornt/charms/precise/landscape-client/container-relation-joined-test

Revision history for this message
Chris Glass (tribaal) wrote :

Looks great! This is really nice. +1

[1]
+class JujuBroker:
and
+class LandscapeBroker:

Nitpick: maybe use new-style classes by subclassing object?

[2]
+ If the client has already been configured, not registration attempt

Small typo s/not/no/ (was not your code).

review: Approve

« Back to merge proposal