Code review comment for lp://staging/~berolinux/linaro-android-build-tools/support-dual-toolchain-tarballs

Revision history for this message
Bernhard Rosenkraenzer (berolinux) wrote :

find/head is copied from the old-style build and can probably be simplified a bit - but I'd prefer to leave it in:
find also has the advantage of making sure we get an absolute path there.

I don't expect to use wildcards right now, but I think at some point they may make sense, so there's no point in disallowing them by not using head -- I can for example picture having

TOOLCHAIN_TYPE="*-androideabi"

in a build that can - depending on the toolchain tarball - end up using arm-linux-androideabi (over arm-eabi) or armv8-linux-androideabi (over armv8-eabi) or the exact opposite.

As for the naming, the other names may be better, let's talk to Michael.

« Back to merge proposal