Code review comment for lp://staging/~berolinux/linaro-android-build-tools/support-dual-toolchain-tarballs

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Do you expect for toolchain TOOLCHAIN_TYPE to ever contain wildcards? If no, then whole find/head is apparently superfluous, and there would be direct assignment.

Also, is TOOLCHAIN_TYPE really good name for it? Not TOOLCHAIN_ARCH, TOOLCHAIN_TARGET, TOOLCHAIN_TRIPLET (not suggesting any of them, just asking for consideration). And actually, this falls into what was suggested by Michael Hope at that Parametrization session - to use consistent naming across Linaro teams, so maybe worth checking with him right away?

« Back to merge proposal