Merge lp://staging/~benji/landscape-client/bug-1428826-restore-register-function-public-API into lp://staging/~landscape/landscape-client/trunk
| Status: | Merged |
|---|---|
| Approved by: | Benji York |
| Approved revision: | 816 |
| Merged at revision: | 813 |
| Proposed branch: | lp://staging/~benji/landscape-client/bug-1428826-restore-register-function-public-API |
| Merge into: | lp://staging/~landscape/landscape-client/trunk |
| Diff against target: |
168 lines (+91/-18) 2 files modified
landscape/configuration.py (+25/-15) landscape/tests/test_configuration.py (+66/-3) |
| To merge this branch: | bzr merge lp://staging/~benji/landscape-client/bug-1428826-restore-register-function-public-API |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Adam Collard (community) | Approve | ||
| Björn Tillenius (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Instead of running client configuration as an independent executable
(which would have been preferable), the client charm reaches inside and
calls the register() function directly. That has resulted in a
dependency on register()'s API which was not enforced via testing or
documented in register()'s docstring.
This branch restores the API the charm depends on, adds documentation as
to its meaning and importance, and adds tests that will warn us if the
API is broken in the future.
Description of the change
Instead of running client configuration as an independent executable (which would have been preferable), the client charm reaches inside and calls the register() function directly. That has resulted in a dependency on register()'s API which was not enforced via testing or documented in register()'s docstring.
This branch restores the API the charm depends on, adds documentation as to its meaning and importance, and adds tests that will warn us if the API is broken in the future.
| Benji York (benji) | # |
| Adam Collard (adam-collard) | # |
+1. I have some minor inline comment on style.