lp://staging/~benji/landscape-client/bug-1428826-restore-register-function-public-API

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/~landscape/landscape-client/trunk at revision 813

Adam Collard (community): Approve on 2015-03-10

Björn Tillenius (community): Approve on 2015-03-09

Diff: 168 lines (+91/-18)

2 files modified

landscape/configuration.py (+25/-15)
landscape/tests/test_configuration.py (+66/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1428826: register() function is a public API without tests and has changed

High

Fix Released

Link a bug report

Related blueprints

816. By Benji York on 2015-03-10

fix docstring/comment bugs

815. By Benji York on 2015-03-10

make providing a reactor optional (for the client charm)

814. By Benji York on 2015-03-09

A few small review changes:

- tweak a test so as to record the fact that a function got called
  and then assert that it didn't instead of making it call
  self.fail() when called
- add some commentary about the charm's use of register() in an
  additional place

813. By Benji York on 2015-03-06

restore legacy API used by client charm and add tests to make sure it is maintained

812. By Benji York on 2015-03-04

Merge better-self-signed-cert-ux-3 [f=] [r=bjornt,danilo] [a=Benji York]
This branch is a pure refactoring of the way the client configuration
communicates so as to separate the UI and network code in preparation
for better SSL error handling and user interaction.

Tests were then able to be improved -- but not as far as we would like.

Notes from Chris:

Most of the code breaks out nested function declaration to make them
easier to test, using functools.partial to keep the invocation sane in a
twisted context (test them "flat", use functools to pass closures to
event handlers).

We used manual stubs instead of mocks for readability and personal
preference [of both of us].

811. By Benji York on 2015-03-03

Merge faster-test-run [f=] [r=bjornt,free.ekanayaka,chad.smith] [a=Benji York]
A couple of tests inject dpkg failures which are retried 12 times with a 5 second sleep between. For test that's unneccesary, so this branch sets the sleep time to zero for those tests.

810. By Adam Collard on 2015-01-22

Don't use Python 2.7isms in the test suite (needs to run on Lucid) [trivial] [r=tribaal]

809. By Chris Glass on 2015-01-22

Removed unused instance variable [trivial][r=sparkiegeek]

808. By Fernando Correa Neto <email address hidden> on 2015-01-12

Merge retry-apt-update [f=1398090] [r=danilo,free.ekanayaka] [a=Fernando Correa Neto]
Change the package reporter so it retries running apt-get update when an error 100 is returned, pretty much in the same way the charm code does it.

807. By Chris Glass on 2015-01-12

Merge more-information-on-ssl-errors [f=1409700] [r=danilo,free.ekanayaka] [a=Chris Glass]
Add a specific error message when the cause of registration failure is an SSL error.