Code review comment for lp://staging/~benji/landscape-client/better-self-signed-cert-ux-3

Revision history for this message
Benji York (benji) wrote :

> What do you think?

I haven't taken the time to look deeply into your proposed test approach, but I agree with everything you said. Unfortunately, the amount of time invested in this branch thus far means that the size of the marginal improvement must be very large for it to be worth it and regrettably, that's not the case.

I plan on keeping the test approach in mind for the next time we work on this code (which I hope is soon, it needs quite a bit of help).

Thank you for the review.

« Back to merge proposal