Code review comment for lp://staging/~benji/landscape-client/better-self-signed-cert-ux-3

Revision history for this message
Данило Шеган (danilo) wrote :

Yes, agreed re better tests: I don't think it's worth it.

I am happy about the Christ not having an opinion on this branch :)

As for Chris, pair programming usually does lead to better code, but at the same time can result in two minds agreeing to decisions and never re-questioning them after the original agreement (I've been guilty of the same thing).

Anyway, my overall assesement is that this is improvement over the existing code (and tests are no worse) which is reflected in my approval :)

« Back to merge proposal