Reviewers: mp+183642_code.launchpad.net,
Message: Please take a look.
Description: Normalize transform to fix IE test
IE uses spaces rather than ',' in transform/translate strings.
https://code.launchpad.net/~bcsaller/juju-gui/bundlesOnIE/+merge/183642
(do not edit description out of merge proposal)
Please review this at https://codereview.appspot.com/13441046/
Affected files: A [revision details] M test/test_bundle_module.js
Index: [revision details] === added file '[revision details]' --- [revision details] 2012-01-01 00:00:00 +0000 +++ [revision details] 2012-01-01 00:00:00 +0000 @@ -0,0 +1,2 @@ +Old revision: <email address hidden> +New revision: <email address hidden>
Index: test/test_bundle_module.js === modified file 'test/test_bundle_module.js' --- test/test_bundle_module.js 2013-08-30 21:28:11 +0000 +++ test/test_bundle_module.js 2013-09-03 10:38:09 +0000 @@ -70,6 +70,10 @@ }); }
+ function normalizeTranslate(translateStr) { + return translateStr.replace(',', ' '); + } + it('should create a proper service for each model', function(done) { promiseBundle() .then(function(bundle) { @@ -89,7 +93,8 @@ assert.equal(service.attr('width'), '96'); assert.equal(service.attr('height'), '96'); // Annotations - assert.equal(service.attr('transform'), 'translate(115,89)'); + assert.equal(normalizeTranslate(service.attr('transform')), + 'translate(115 89)'); // Ensure that we've exposed one service assert.equal(container.all('.exposed-indicator').size(), 1); var indicator = selection.select('.exposed-indicator');
« Back to merge proposal
Reviewers: mp+183642_ code.launchpad. net,
Message:
Please take a look.
Description:
Normalize transform to fix IE test
IE uses spaces rather than ',' in transform/translate strings.
https:/ /code.launchpad .net/~bcsaller/ juju-gui/ bundlesOnIE/ +merge/ 183642
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/13441046/
Affected files: bundle_ module. js
A [revision details]
M test/test_
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>
Index: test/test_ bundle_ module. js bundle_ module. js' bundle_ module. js 2013-08-30 21:28:11 +0000 bundle_ module. js 2013-09-03 10:38:09 +0000
=== modified file 'test/test_
--- test/test_
+++ test/test_
@@ -70,6 +70,10 @@
});
}
+ function normalizeTransl ate(translateSt r) { replace( ',', ' '); ndle() then(function( bundle) {
assert. equal(service. attr('width' ), '96');
assert. equal(service. attr('height' ), '96'); equal(service. attr('transform '), 'translate( 115,89) '); equal(normalize Translate( service. attr('transform ')),
assert. equal(container .all('. exposed- indicator' ).size( ), 1); select( '.exposed- indicator' );
+ return translateStr.
+ }
+
it('should create a proper service for each model', function(done) {
promiseBu
.
@@ -89,7 +93,8 @@
// Annotations
- assert.
+ assert.
+ 'translate(115 89)');
// Ensure that we've exposed one service
var indicator = selection.