Code review comment for lp://staging/~barry/launchpad/428957-karma

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 merge approved

Looks sensible to me.

Aaron

Barry Warsaw wrote:
> Barry Warsaw has proposed merging lp:~barry/launchpad/428957-karma into lp:launchpad/devel.
>
> Requested reviews:
> Aaron Bentley (abentley)
>
> reviewer abentley
>
> = Summary =
>
> Bug 428957 describes a small fallout from my previous landing of the
> ~person/+karma page conversion. I accidentally displayed
> self.user.displayname in the H1 heading instead of self.context.displayname
> (i.e. I was displaying the user instead of the person).

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkquWqYACgkQ0F+nu1YWqI0q9QCeNG8xazofvTXhdIGiC1M3736u
hvUAnROKWFg8hh5ix1wJPjqdGjqLdn30
=pBab
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal