(1) Revert r358, which doesn't seem to be necessary anymore. At least I cannot reproduce bug #1048348 when reverting r358: the "missing" icon is shown for all themes that don't have system-devices-panel. The icon is also properly updated when the theme changes. Maybe this was an issue in GtkImage that has since been fixed?
(2) Specifiy that the default icon fallbacks ("system-devices-panel", "system-devices", "system") should be used, so that themes that don't have "system-devices-panel" fall back to "system".
I like both changes, but would appreciate someone else confirming (1) before this gets merged.
Sorry for misleading you last Friday, Mathieu. I didn't have enough time to look at this in detail.
This patch fixes two unrelated things:
(1) Revert r358, which doesn't seem to be necessary anymore. At least I cannot reproduce bug #1048348 when reverting r358: the "missing" icon is shown for all themes that don't have system- devices- panel. The icon is also properly updated when the theme changes. Maybe this was an issue in GtkImage that has since been fixed?
(2) Specifiy that the default icon fallbacks ("system- devices- panel", "system-devices", "system") should be used, so that themes that don't have "system- devices- panel" fall back to "system".
I like both changes, but would appreciate someone else confirming (1) before this gets merged.
Sorry for misleading you last Friday, Mathieu. I didn't have enough time to look at this in detail.