Code review comment for lp://staging/~ballogy/gdesklets/optional-use-gconf-appindicator

Revision history for this message
Ronny Lorenz (raumzeit) wrote :

I dont mind merging those changes into gdesklets. The gconf modification
seems reasonable to me but maybe we should make the optional
appindicator stuff behave differently. With the currently proposed
changes the drawback will be that during compile time one can not decide
to never ever use appindicator at all. It will be loaded and used as
soon as its modules are available during runtime...
I dont know if this is what we intend to do? It would be nice to still
be able to deactivate appindicator by all means.

Just my 2cents

Ronny

On 03/11/2012 11:09 AM, Bjoern Koch wrote:
> First if all: sorry for the late reply... :/.
>
> Anyway... to me this looks pretty good and (IMHO) we could merge these changes.
> But I guess we will first have to discuss this on the ML.

« Back to merge proposal