Code review comment for lp://staging/~ballogy/bamf-qt/fix-imports-dir-location

Revision history for this message
Olivier Tilloy (osomon) wrote :

> I don't know how to truncate the path, but it's really required to be
> relative? I think that it's a Qt plugin, and therefore it should be installed
> into the same place where Qt installed. E.g. appmenu-qt uses the similar
> QT_PLUGINS_DIR variable, which is also an absolute patch and cannot be
> prefixed:
> http://bazaar.launchpad.net/~agateau/appmenu-
> qt/trunk/view/head:/src/CMakeLists.txt#L37

You have a point here!
I guess in this situation having an absolute path is fine. Let’s merge it as is then!

review: Approve

« Back to merge proposal