Code review comment for lp://staging/~bac/launchpad/bug-430748-team-mailinglist

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Hi Brad,

This branch looks good. I just have one thing that I stumbled upon when looking at your changes that would make a good drive-by cleanup.

merge-approved

Can you make this change?

        <browser:page
            for="lp.registry.interfaces.person.ITeam"
            permission="launchpad.MailingListManager"
- class="canonical.launchpad.browser.TeamMailingListConfigurationView"
+ class="lp.registry.browser.team.TeamMailingListConfigurationView"
            name="+mailinglist"
            template="../templates/team-mailinglist.pt"/>

-Edwin

review: Approve (code)

« Back to merge proposal