Code review comment for lp://staging/~bac/juju-quickstart/get_os_version

Revision history for this message
Brad Crittenden (bac) wrote :

*** Submitted:

Add a function for determing OS flavor.

Determines OS and then for the case of Linuxes, determines whether the
system uses apt-get or RPM.

R=frankban
CC=
https://codereview.appspot.com/99410054

https://codereview.appspot.com/99410054/diff/20001/quickstart/platform_support.py
File quickstart/platform_support.py (right):

https://codereview.appspot.com/99410054/diff/20001/quickstart/platform_support.py#newcode22
quickstart/platform_support.py:22: )
On 2014/05/23 13:56:35, frankban wrote:
> In the other quickstart modules we separate the __future__ imports
from the
> other ones, considering them a special case. This is not required by
PEP8, so
> change it only if you like the idea.

Done.

https://codereview.appspot.com/99410054/diff/20001/requirements.pip
File requirements.pip (right):

https://codereview.appspot.com/99410054/diff/20001/requirements.pip#newcode26
requirements.pip:26: # here when moving to a newer jujuclient that fixes
that does correctly
On 2014/05/23 13:56:35, frankban wrote:
> s/that fixes //

Done.

https://codereview.appspot.com/99410054/diff/20001/requirements.pip#newcode32
requirements.pip:32:
On 2014/05/23 13:56:35, frankban wrote:
> Blank line?

Done.

https://codereview.appspot.com/99410054/

« Back to merge proposal