Merge lp://staging/~bac/juju-quickstart/donde-brew into lp://staging/juju-quickstart
Proposed by
Brad Crittenden
Status: | Merged |
---|---|
Merged at revision: | 81 |
Proposed branch: | lp://staging/~bac/juju-quickstart/donde-brew |
Merge into: | lp://staging/juju-quickstart |
Diff against target: |
366 lines (+136/-60) 7 files modified
quickstart/app.py (+1/-1) quickstart/manage.py (+15/-5) quickstart/platform_support.py (+25/-11) quickstart/settings.py (+3/-1) quickstart/tests/test_app.py (+1/-1) quickstart/tests/test_manage.py (+25/-14) quickstart/tests/test_platform_support.py (+66/-27) |
To merge this branch: | bzr merge lp://staging/~bac/juju-quickstart/donde-brew |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email: mp+223012@code.staging.launchpad.net |
Description of the change
Fail early if brew is not installed.
Did some refactoring to list required files for each supported platform.
If required files are not found, fail early with an appropriate parser
error message.
To post a comment you must log in.
Reviewers: mp+223012_ code.launchpad. net,
Message:
Please take a look.
Description:
Fail early if brew is not installed.
Did some refactoring to list required files for each supported platform.
If required files are not found, fail early with an appropriate parser
error message.
https:/ /code.launchpad .net/~bac/ juju-quickstart /donde- brew/+merge/ 223012
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/108930045/
Affected files (+105, -4 lines): manage. py platform_ support. py tests/test_ manage. py tests/test_ platform_ support. py
A [revision details]
M quickstart/
M quickstart/
M quickstart/
M quickstart/