Code review comment for lp://staging/~azzar1/unity/lockscreen

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Thanks for the work, some questions:
>
> - > Also allow to fallback to lightdm + greeter (tty switching) in case you
> need more pam power.
>
> How do you fallback? Do you plan to put a widget on the lock screen that sends
> you to the greeter?
>

Yeah the branch already does that.

>
> - the pam integration doesn't seem a small detail to handle. Robert, do you
> think it's possible to copy the one from lightdm? (I don't know how much
> that's a separate part of code that can be copied/reused)

I don't think it's possible.

>
> - the lock_screen_type options has none/lightdm/custom, what does "custom"
> mean there? would that allow use to keep using gnome-screensaver instead of
> unity if needed?

None allow to uses gnome-screensaver or whatever you want, custom it's just unity.
I should change name.

« Back to merge proposal