Code review comment for lp://staging/~azzar1/unity/lockscreen

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

PanelView: I guess you don't want to add a tray also in lockscreen mode, right? :)
I'd like also if you'd use a struct to initialize more than a bool.

LockScreenSettings: why don't you use the same approach I used for decoration::Settings? It might also help testing...
Also you miss an #include <NuxCore/Property.h>

You miss a lot of includes (I'm not using pch here), and so I get a lot of errors:

#include <NuxGraphics/GLTextureResourceManager.h> // for nux::BaseTexture
Why not a forward declaration?

Anyway, in general it doesn't compile here... I'm getting tons of errors without pch enabled. :(

« Back to merge proposal