Code review comment for lp://staging/~axwalk/juju-core/wire-up-prechecker

Apart from the extra attrs, this seems fine -- but they could use a spot
more investigation.

https://codereview.appspot.com/14032043/diff/19001/juju/conn.go
File juju/conn.go (right):

https://codereview.appspot.com/14032043/diff/19001/juju/conn.go#newcode171
juju/conn.go:171: func (c *Conn) setPrechecker() error {
On 2013/10/08 09:52:34, axw wrote:
> On 2013/10/08 07:30:42, fwereade wrote:
> > Good point in your comment that I think was around here. Let's use
this to set
> > the environ on the Conn itself -- I can't think of a good reason not
to tbh.

> Done. It's slightly more complicated than getting the env from state:
it needs
> to have the admin-secret and ca-private-key copied across from the
input
> environ.

/me has a suspicious. Shouldn't we do it after updating secrets?

https://codereview.appspot.com/14032043/diff/30001/cmd/jujud/machine.go
File cmd/jujud/machine.go (right):

https://codereview.appspot.com/14032043/diff/30001/cmd/jujud/machine.go#newcode245
cmd/jujud/machine.go:245: // TODO(axw) 2013-10-01 bug #pending
needs a bug# now :)

https://codereview.appspot.com/14032043/diff/30001/juju/conn.go
File juju/conn.go (right):

https://codereview.appspot.com/14032043/diff/30001/juju/conn.go#newcode106
juju/conn.go:106: "ca-private-key": string(caPrivateKey),
Yeah, I don't *think* we should need these.

https://codereview.appspot.com/14032043/