Code review comment for lp://staging/~axwalk/juju-core/lp1281071-rsyslog-worker-tls

https://codereview.appspot.com/68930045/diff/20001/log/syslog/config.go
File log/syslog/config.go (right):

https://codereview.appspot.com/68930045/diff/20001/log/syslog/config.go#newcode57
log/syslog/config.go:57: $DefaultNetstreamDriverCAFile {{tlsCACertPath}}
On 2014/02/27 06:22:38, thumper wrote:
> I know all this is going to conflict with Ian's branch we he changes
the
> behaviour to use a struct.

Nah, Ian's stuff just changed the tests. We should probably do the same
thing here, but really it's not that important.

https://codereview.appspot.com/68930045/diff/20001/worker/rsyslog/worker.go
File worker/rsyslog/worker.go (right):

https://codereview.appspot.com/68930045/diff/20001/worker/rsyslog/worker.go#newcode175
worker/rsyslog/worker.go:175: var lookupUser = func(username string)
(uid, gid int, err error) {
On 2014/02/27 06:22:38, thumper wrote:
> useful elsewhere?

I'd rather not institutionalise it, because this will only work on *Nix
(other OSes, such as Windows, may have non-integer Uid/Gid). I'll keep
an eye out for people doing the same thing.

https://codereview.appspot.com/68930045/