Code review comment for lp://staging/~attente/unity-settings-daemon/fcitx-transition

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, looks mostly fine, some comments:

- we shouldn't recommend both ibus and fcitx from the settings daemon, we should rather seed fcitx if we want it installed by default

- we need to have the fcitx MIR approved because we can land the changes, since it adds a build-depends on packages which are currently in universe

- looks fine to land otherwise

setting needs fixing for the recommend, then it's good to go, once the fcitx MIR is ready

review: Needs Fixing

« Back to merge proposal