git-ubuntu

Merge ~athos-ribeiro/git-ubuntu:leaking-perl-with-wrappers into git-ubuntu:master

  1. Git
  2. lp:~athos-ribeiro/git-ubuntu
  3. leaking-perl-with-wrappers
  4. Merge into master
Proposed by Athos Ribeiro
Status: Merged
Merged at revision: d1858ecfceb25e7e68811da5e66ca81df6657e0d
Proposed branch: ~athos-ribeiro/git-ubuntu:leaking-perl-with-wrappers
Merge into: git-ubuntu:master
Diff against target: 190 lines (+82/-16)
10 files modified
gitubuntu/integration_test.py (+47/-15)
snap-wrappers/wrappers/dch (+3/-0)
snap-wrappers/wrappers/dpkg-mergechangelogs (+3/-0)
snap-wrappers/wrappers/dpkg-parsechangelog (+3/-0)
snap-wrappers/wrappers/dpkg-source (+3/-0)
snap-wrappers/wrappers/pristine-bz2 (+3/-0)
snap-wrappers/wrappers/pristine-gz (+3/-0)
snap-wrappers/wrappers/pristine-tar (+3/-0)
snap-wrappers/wrappers/pristine-xz (+3/-0)
snap/snapcraft.yaml (+11/-1)
Reviewer Review Type Date Requested Status
Robie Basak Approve
Server Team CI bot continuous-integration Approve
Canonical Server Pending
git-ubuntu developers ci Pending
Review via email: mp+419144@code.staging.launchpad.net

Description of the change

This is the first part of the split for https://code.launchpad.net/~athos-ribeiro/usd-importer/+git/usd-importer/+merge/416951.

Here we have the fix for the leaking perl issue and related tests.

As discussed with Robie (offline), I added the following changes:

- Use wrappers instead of shebang hack
- Add smoke tests for the commands being wrapped

The fixes for the fallback functions present in the former MP will follow in a separate merge proposal after this one is merged.

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:e4914bd98800056343d52d3d31b444ac920b0749
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/79/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    FAILED: Unit Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/79//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:35220daac4f1feac10321fbfb271f8868091453a
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/80/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/80//rebuild

review: Approve (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:94d3a81671affb2abdb6345b5397812fb84472e6
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/2/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/2//rebuild

review: Approve (continuous-integration)
Revision history for this message
Robie Basak (racb) wrote :

Perfect. Thanks!

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches