git-ubuntu

Merge ~athos-ribeiro/git-ubuntu:leaking-perl into git-ubuntu:master

  1. Git
  2. lp:~athos-ribeiro/git-ubuntu
  3. leaking-perl
  4. Merge into master
Proposed by Athos Ribeiro
Status: Rejected
Rejected by: Robie Basak
Proposed branch: ~athos-ribeiro/git-ubuntu:leaking-perl
Merge into: git-ubuntu:master
Diff against target: 150 lines (+64/-3)
4 files modified
gitubuntu/git_repository.py (+2/-2)
gitubuntu/git_repository_test.py (+29/-0)
gitubuntu/integration_test.py (+23/-0)
snap/snapcraft.yaml (+10/-1)
Reviewer Review Type Date Requested Status
Robie Basak Needs Fixing
Server Team CI bot continuous-integration Approve
Canonical Server Pending
git-ubuntu developers ci Pending
Review via email: mp+416951@code.staging.launchpad.net

Description of the change

Using the git-ubuntu snap in jammy after the latest perl update results in erros due to an issue with some dpkg error fallback codepaths. Fixing this issue is one of the items addressed in this MP.

The reason the fallback codepath is being triggered in jammy is due to jammy's and focal's perl libraries incompatibilities. The snap executes some of its scripts through shebangs, calling the host's perl binary, resulting in mixed, incompatible environments. This MP addressed the issue by ensuring the binaries called by the snap are available in the snap and run with the perl tools also available in the snap.

Finally, while some tests were included, their real value is when they are triggered from the installed snap in a jammy host (git-ubuntu.self-test).

A test snap can be found at https://jenkins.ubuntu.com/server/view/git-ubuntu/job/git-ubuntu-ci/78/

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:5eb05441120c06dd7a927255f6f98ec848b8cf0b
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/64/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/64//rebuild

review: Approve (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:428ac057474bddb749f6f241a519b0c3edc914e1
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/65/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    FAILED: Unit Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/65//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:494f22d496520c9f5051b4c1347c53f579d98cec
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/66/
Executed test runs:
    SUCCESS: VM Setup
    FAILED: Build

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/66//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:72a277e2771cbf6d4b262e29e11e8c414f84c9df
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/67/
Executed test runs:
    SUCCESS: VM Setup
    FAILED: Build

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/67//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:a3c07d641f766be68ecf32bcc81c00725756df1a
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/68/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    FAILED: Unit Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/68//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:d27c1fed856bd374a8768197606849c9d266a63a
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/69/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    FAILED: Unit Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/69//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:56fc0e3cd6a9532122fbe8e5880373f5d04c80d0
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/70/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    FAILED: Unit Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/70//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:b424ed953724c06a47069e85a095dda44abbceb3
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/71/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/71//rebuild

review: Approve (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:25f675b8b862c8d03e5272aa5719c22172a717c4
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/72/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/72//rebuild

review: Approve (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:20be7467a5e70c7e47e795b5458a4573fc3ba4be
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/73/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/73//rebuild

review: Approve (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:1bc066cc6c87230e09bfeba8a457b4a3170a99a4
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/74/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/74//rebuild

review: Approve (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:b256e5bcd2ad6eb4527290fed6f8876ee95fd675
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/75/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/75//rebuild

review: Approve (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:789d14cba4afbfe320869c1e5fbbb221db099416
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/76/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/76//rebuild

review: Approve (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:cd75b9ba7dc9e72f454f1f81838c7ebc58700e66
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/77/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/77//rebuild

review: Approve (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:d7460d21e1de0c41bfdd4c8c80c1c7e2027b6f23
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/78/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/78//rebuild

review: Approve (continuous-integration)
Revision history for this message
Robie Basak (racb) wrote :

Summary of realtime chat with Athos:

1) Split out sed changelog parsing changes to separate MP; 2) Adjust main fix to use pattern of wrappers in $SNAP/usr/local/bin instead of a shebang that requires on host /usr/bin/env using existing pattern; 3) Test endpoints directly in separate test as much as possible using existing pattern.

review: Needs Fixing
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

This MP will be split into 2 different MPs.

Here is the first one of the series: https://code.launchpad.net/~athos-ribeiro/usd-importer/+git/usd-importer/+merge/419144

Revision history for this message
Robie Basak (racb) wrote :

Marking this MP as Rejected as it has been superseded.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches