Merge lp://staging/~asdfghjkl-deactivatedaccount1/python-imaging/gif-fix into lp://staging/python-imaging

Proposed by asdfghjkl
Status: Rejected
Rejected by: Edwin Grubbs
Proposed branch: lp://staging/~asdfghjkl-deactivatedaccount1/python-imaging/gif-fix
Merge into: lp://staging/python-imaging
Diff against target: 29 lines (+3/-2)
1 file modified
PIL/GifImagePlugin.py (+3/-2)
To merge this branch: bzr merge lp://staging/~asdfghjkl-deactivatedaccount1/python-imaging/gif-fix
Reviewer Review Type Date Requested Status
Edwin Grubbs Needs Resubmitting
Review via email: mp+59545@code.staging.launchpad.net

Description of the change

This change fixes a bug in which frames subsequent to the first of an animated GIF take on incorrect palette attributes, resulting in greyscale images.

Since GifImageFile.seek() references the same palette object between frames, palette changes which should be local (such as those made by Image.load()) get persisted. This change takes a shallow copy of the global palette for each frame, thus isolating local palette changes.

To post a comment you must log in.
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

PIL development is not done on Launchpad. You will need to submit your patch by contacting this mailing list.

http://mail.python.org/mailman/listinfo/image-sig

The PIL code base is mirrored on Launchpad to make it easier to apply patches for the Ubuntu PIL packages, but it looks like your patch belongs in the upstream PIL project.

review: Needs Resubmitting

Unmerged revisions

16. By asdfghjkl

use a fresh palette for each frame

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: