Code review comment for lp://staging/~artmello/webbrowser-app/webbrowser-app-bookmark_folders

Revision history for this message
Bill Filler (bfiller) wrote :

Some comments that need to be fixed (some dupes of Olivier's). You should run on the device to see some of these.

1) turn off predictive text hint for entry field in Save dialog
2) pressing the Save button in the dialog doesn't close it on the device, it only dismisses the keyboard but doesn't close the dialog
3) I think we really need a "Dismiss" button in the initial popover. Not clear how to close it, especially on device
4) On device, if the list of bookmark folders is too big it pushes the popover above the url field
5) On the bookmarks page, the "More" button is too big. I thought this was supposed to be a "See more.." link at the bottom of the bookmarks list, not a button to the right? If we leave it a button, please reduce the size. Same with less button.
6) Hide folders that are empty in the more view
7) Instead of using the + -, use right arrow and down arrow icons if we have them, if not don't show anything. Just allow clicking the section to expand/collapse.

review: Needs Fixing

« Back to merge proposal