Code review comment for lp://staging/~artmello/webbrowser-app/webbrowser-app-bookmark_folders

Revision history for this message
Olivier Tilloy (osomon) wrote :

> > The SQL "bookmarks" table should probably have a foreign key constraint on
> > folderId. See https://www.sqlite.org/foreignkeys.html.
>
> It seems that Foreign Key support is disabled by default and need to be
> enabled setting the PRAGMA foreign_keys. But it is not possible to enable it
> in a multi-statement transaction so we would need to set it before each
> relevant transaction in the bookmarks-model. I think that could be error prone
> but can be done for sure. What do you think? Or maybe there is another way to
> do it that I am missing.

Looks like too much hassle for little benefit. Let’s forget about it.

« Back to merge proposal