Code review comment for lp://staging/~andrewjbeach/juju-ci-tools/bootstrap-args

Revision history for this message
Aaron Bentley (abentley) wrote :

Thanks for explaining. Sorry I missed the EnvJujuClient2A2 implementation. Ideally that would have the same signature as the EnvJujuClient implementation, but it seems to have diverged considerably without causing actual problems, so I guess we don't need to address that right now.

Aside from a couple of typos, this is good to land. I do have a couple of suggestions for the get_bootstrap_args logic, but they're not required.

review: Approve

« Back to merge proposal