Mir

Code review comment for lp://staging/~andreas-pokorny/mir/map-touchscreen-to-output

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

> If preferred_mode_index is incorrect then so is current_mode_index. Because in
> the near future we'll have a logical output size that's different to the
> current mode dimensions (bug 1639226). So the current mode dimensions must be
> ignored. Instead please use "extents().size" to get the correct size of the
> output in the scene.

So you are requiring a change based on an future change that may or may not affect the validity of the modes vector?

But you do understand that I do need an untransformed coordinate range for the x and y axis of the touchscreen? I can use the preferred_mode_index as a basis for that, but then I need to do additional scaling after that to get to the current mode. Or instead use the current size directly.
extents().size would be incorrect now and later since it already applies rotation.

I do think about changing the Output to expose a transformation matrix instead of the output orientation and output position. But then still libinput needs an output size.

« Back to merge proposal