Merge lp://staging/~andrea.corbellini/software-properties/fix-621977 into lp://staging/software-properties
Proposed by
Andrea Corbellini
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~andrea.corbellini/software-properties/fix-621977 |
Merge into: | lp://staging/software-properties |
Diff against target: |
307 lines (+44/-40) 2 files modified
add-apt-repository (+13/-10) softwareproperties/SoftwareProperties.py (+31/-30) |
To merge this branch: | bzr merge lp://staging/~andrea.corbellini/software-properties/fix-621977 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrea Corbellini (community) | Needs Resubmitting | ||
Barry Warsaw (community) | Needs Fixing | ||
Robert Roth (community) | Approve | ||
Review via email:
|
Description of the change
This branch fixes bug #621977 in the following way:
1. deb-src lines are added, but commented out, so that Software Properties still lets you enable them later;
2. a new -s, --enable-source command line option is added so that you can add uncommented deb-src line with a single command.
To post a comment you must log in.
Unmerged revisions
- 822. By Andrea Corbellini
-
Do not enable deb-src lines by default.
The patch looks fine with one minor detail: lots of unchanged lines are added to the diff (probably because tab/spaces usage - whitespace differences). It would be nice if you could set up your editor to use spaces instead of tabs (I think software-properties uses spaces instead of tabs) to avoid harder-to-review diffs, because the reviewer has to filter the real changes.
Other than that: nice solution to comment the source line by default, but leave an option to enable the source with the same command.