Code review comment for lp://staging/~andrea-gualano/a4/rendering
Revision history for this message
| Andrea Corbellini (andrea.corbellini) wrote | # |
review:
Needs Information
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
Hi and thanks for your branch. It looks fine, but I have a question: if I make the window smaller than the image, why the image is kept at its original size? Is it just a flaw or the desired behavior?
Also, please follow the naming conventions described in PEP8 (scaleX => scale_x) and add a docstring to render().