Merge ~andersson123/auto-upgrade-testing-specifications:check_conf_file_prompt into auto-upgrade-testing-specifications:main

Proposed by Tim Andersson
Status: Merged
Merged at revision: d97eddc30c9131951fb1ce703c9e0f82017c2bdc
Proposed branch: ~andersson123/auto-upgrade-testing-specifications:check_conf_file_prompt
Merge into: auto-upgrade-testing-specifications:main
Diff against target: 376 lines (+53/-0)
34 files modified
profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-jammy-kinetic-basic-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-jammy-kinetic-desktop-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-jammy-kinetic-kubuntu-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-jammy-kinetic-lubuntu-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-jammy-kinetic-ubuntu-mate-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-jammy-kinetic-xubuntu-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-kinetic-lunar-basic-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-kinetic-lunar-desktop-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-kinetic-lunar-kubuntu-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-kinetic-lunar-lubuntu-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-kinetic-lunar-ubuntu-mate-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-kinetic-lunar-ubuntu-unity-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-kinetic-lunar-xubuntu-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-lunar-mantic-basic-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-lunar-mantic-desktop-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-lunar-mantic-kubuntu-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-lunar-mantic-lubuntu-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-lunar-mantic-ubuntu-mate-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-lunar-mantic-ubuntucinnamon-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-lunar-mantic-xubuntu-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-xenial-bionic-basic-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-xenial-bionic-basic-i386_qemu.yaml (+1/-0)
profiles/ubuntu-xenial-bionic-desktop-amd64_qemu.yaml (+1/-0)
profiles/ubuntu-xenial-bionic-desktop-i386_qemu.yaml (+1/-0)
tests/check-conffile-prompt (+20/-0)
Reviewer Review Type Date Requested Status
Paride Legovini Approve
Brian Murray (community) Needs Fixing
Review via email: mp+444554@code.staging.launchpad.net

Commit message

add check for conf file prompt in upgrade log

Description of the change

add check for conf file prompt in upgrade log

To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) :
review: Needs Fixing
Revision history for this message
Tim Andersson (andersson123) wrote :

Amended all, the no new line thing was baffling, I am using vim and I'm not sure why it is not there.

Revision history for this message
Paride Legovini (paride) :
review: Needs Fixing
Revision history for this message
Brian Murray (brian-murray) wrote :

A cursory look at the source code of dpkg and prompts that appear in ubuntu-release-upgrader log files leads me to believe that the proper term is "conffile". Subsequently, I'd prefer that all references to it were consistent and used "conffile" and not "conf-file" or "conf file". Feel free to double check my research though!

review: Needs Fixing
Revision history for this message
Tim Andersson (andersson123) wrote :

Addressed both of your comments :)

Revision history for this message
Paride Legovini (paride) wrote :

Looks good, thanks!

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: