Code review comment for lp://staging/~allenap/launchpad/ui-convert-malone-index-3.0-bug-416942

Revision history for this message
Gavin Panella (allenap) wrote :

I also remembered I meant to remove MaloneContextMenu as it's unused, so here's a small additional diff for that:

=== modified file 'lib/canonical/launchpad/zcml/launchpad.zcml'
--- lib/canonical/launchpad/zcml/launchpad.zcml 2009-09-03 12:36:28 +0000
+++ lib/canonical/launchpad/zcml/launchpad.zcml 2009-09-04 15:32:52 +0000
@@ -322,11 +322,6 @@
       classes="LaunchpadRootFacets"
       />

- <browser:menus
- module="lp.bugs.browser.malone"
- classes="MaloneContextMenu"
- />
-
   <!-- This is a view on TALES CONTEXTS rather than all dicts. -->
   <browser:page
       for="*"

=== modified file 'lib/lp/bugs/browser/malone.py'
--- lib/lp/bugs/browser/malone.py 2009-09-04 15:06:34 +0000
+++ lib/lp/bugs/browser/malone.py 2009-09-04 15:32:52 +0000
@@ -6,7 +6,7 @@
 __metaclass__ = type
 __all__ = [
     'MaloneApplicationNavigation',
- 'MaloneContextMenu',
+ 'MaloneRelatedPages',
     ]

@@ -16,7 +16,7 @@
 import canonical.launchpad.layers

 from canonical.launchpad.webapp import (
- ContextMenu, Link, Navigation, canonical_url, stepto)
+ Link, Navigation, canonical_url, stepto)
 from canonical.launchpad.webapp.authorization import check_permission
 from canonical.launchpad.webapp.menu import NavigationMenu

@@ -69,16 +69,6 @@
         return bug

-class MaloneContextMenu(ContextMenu):
- # XXX mpt 2006-03-27: No longer visible on Bugs front page.
- usedfor = IMaloneApplication
- links = ['cvetracker']
-
- def cvetracker(self):
- text = 'CVE tracker'
- return Link('cve/', text, icon='cve')
-
-
 class MaloneRelatedPages(NavigationMenu):

     facet = 'bugs'

« Back to merge proposal