Code review comment for lp://staging/~allenap/gwacl/update-role

Revision history for this message
Gavin Panella (allenap) wrote :

> [0]
>
> 14 + RoleName string
> 15 + PersistentVMRole *PersistentVMRole
>
> The PersistentVMRole object already contains the RoleName.

There's nothing in the docs to say that you can't change the name of the role by specifying a different name. In other words, PersistentVMRole defines the role resource, and ServiceName, DeploymentName and RoleName define the resource's location.

Thanks for the review :)

« Back to merge proposal